Restart mullvad-daemon after user grants Full Disk Access (macOS)
#6381
Conversation
mullvad-cli/src/format.rs
Outdated
| println!(); | ||
| println!(r#"Enable "Full Disk Access" for "Mullvad VPN" in the macOS system settings:"#); | ||
| println!(r#"open "x-apple.systempreferences:com.apple.preference.security?Privacy_AllFiles"#); | ||
| println!(); | ||
| println!("Restart the Mullvad daemon for the change to take effect:"); | ||
| println!("launchctl unload -w /Library/LaunchDaemons/net.mullvad.daemon.plist"); | ||
| println!("launchctl load -w /Library/LaunchDaemons/net.mullvad.daemon.plist"); |
There was a problem hiding this comment.
Why not write it using a single println!?
| println!(); | |
| println!(r#"Enable "Full Disk Access" for "Mullvad VPN" in the macOS system settings:"#); | |
| println!(r#"open "x-apple.systempreferences:com.apple.preference.security?Privacy_AllFiles"#); | |
| println!(); | |
| println!("Restart the Mullvad daemon for the change to take effect:"); | |
| println!("launchctl unload -w /Library/LaunchDaemons/net.mullvad.daemon.plist"); | |
| println!("launchctl load -w /Library/LaunchDaemons/net.mullvad.daemon.plist"); | |
| println!(r#" | |
| Enable "Full Disk Access" for "Mullvad VPN" in the macOS system settings: | |
| open "x-apple.systempreferences:com.apple.preference.security?Privacy_AllFiles | |
| Restart the Mullvad daemon for the change to take effect: | |
| launchctl unload -w /Library/LaunchDaemons/net.mullvad.daemon.plist | |
| launchctl load -w /Library/LaunchDaemons/net.mullvad.daemon.plist | |
| "#); |
dlon
force-pushed
the
failed-to-enable-split-tunneling-on-macos-145-intel-des-1034
branch
2 times, most recently
from
ed98887 to
31717ae
Compare
There was a problem hiding this comment.
Reviewed 2 of 5 files at r1, 1 of 3 files at r2, 5 of 5 files at r4, all commit messages.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
gui/src/main/tunnel-state.ts line 24 at r3 (raw file):
Previously, dlon (David Lönnhager) wrote…
IMO, that would be worse. As is,
TunnelStateHandlerdoesn't need to care what the boolean is used for. If it were renamed toshutdownDaemonWhenGuiClosesthen it would couple it (slightly) more with the main class.
Sure, I agree with that argument
MarkusPettersson98
force-pushed
the
failed-to-enable-split-tunneling-on-macos-145-intel-des-1034
branch
from
cad055f to
4c27ce1
Compare
MarkusPettersson98
force-pushed
the
failed-to-enable-split-tunneling-on-macos-145-intel-des-1034
branch
2 times, most recently
from
ea040d8 to
7784c67
Compare
There was a problem hiding this comment.
Reviewed 6 of 6 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
dlon
force-pushed
the
failed-to-enable-split-tunneling-on-macos-145-intel-des-1034
branch
from
79eec40 to
de9beaa
Compare
There was a problem hiding this comment.
Reviewed 1 of 5 files at r4, 3 of 3 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
MarkusPettersson98
force-pushed
the
failed-to-enable-split-tunneling-on-macos-145-intel-des-1034
branch
from
de9beaa to
6d638ee
Compare
- Add option to automatically shutdown daemon on after running through the same safety routine as `PrepareRestart`. This is exposed via a new gRPC call called `PrepareRestartV2`. - Add help text for enabling full disk access to the CLI
MarkusPettersson98
force-pushed
the
failed-to-enable-split-tunneling-on-macos-145-intel-des-1034
branch
from
6d638ee to
751026b
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
MarkusPettersson98
deleted the
failed-to-enable-split-tunneling-on-macos-145-intel-des-1034
branch
This PR fixes an issue where the
mullvad-daemonwould not automatically restart after the user had granted "Mullvad VPN" application Full Disk Access. This is needed to make split tunneling work.This change is